Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow matching exact strings #64

Open
hauleth opened this issue Feb 27, 2019 · 4 comments
Open

Allow matching exact strings #64

hauleth opened this issue Feb 27, 2019 · 4 comments
Labels
1.0 enhancement ExUnit Mimic ExUnit.Case functionality as close as possible Gherkin Suppot gherkin language features
Projects
To the 1.0

Comments

@hauleth
Copy link
Contributor

hauleth commented Feb 27, 2019

Instead of always requiring regular expression it would be worth to sometimes provide exact string to not bother about all anchoring and other cruft, this would short "definitions" of such steps by 4 characters at least.
@nicholasjhenry
Copy link
Collaborator

Related to this is a PR we started on to support "Cucumber Expressions":

https://github.com/civilcode/cabbage/pull/1

@revati
Copy link
Collaborator

revati commented Feb 27, 2019 •
edited

@nicholasjhenry And i found about this jsut now :| Why this isnt still merged?
It seems stuck, last action on third of august.

@revati revati added this to To do in To the 1.0 Feb 27, 2019
@revati revati removed this from To do in To the 1.0 Feb 27, 2019
@revati revati added enhancement ExUnit Mimic ExUnit.Case functionality as close as possible Gherkin Suppot gherkin language features labels Feb 27, 2019
@revati revati added this to To do in To the 1.0 Feb 27, 2019
@nicholasjhenry
Copy link
Collaborator

nicholasjhenry commented Feb 27, 2019 •
edited

@revati I can resolve the conflicts for the PR on Friday if you're OK with accepting the PR as is we can get this merged in. Let me know.

(related to #47)

@revati
Copy link
Collaborator

revati commented Feb 27, 2019

I have written a few comments on it.

@revati revati added the 1.0 label Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 enhancement ExUnit Mimic ExUnit.Case functionality as close as possible Gherkin Suppot gherkin language features
Projects
To the 1.0
  
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicholasjhenry @hauleth @revati