-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
axis.x.tick.fit documentation is incorrect (backwards) #1786
Comments
"If true set, the ticks will be positioned nicely." This is true. In given example when fit is set true, it positioned nicely - ticks appear only where data is. I think your picture of 'positioned nicely' is simply different than one of the author of documentation. |
Hmmm, I can see how the first sentence may be read subjectively. However,
This part appears to be objectively incorrect. If set to false the ticks are positioned evenly, without regard to what the x value of the data points are. In either case the wording should probably be changed to be more explicit. |
I, too, was confused by the documentation regarding this feature. "Positioned nicely" is vague language, and the documentation for the false case is indeed just wrong as @Zerim pointed out. How about changing it to: "If true, ticks will be positioned according to the x value of the data points. If false, ticks will be evenly spaced along the x-axis." It's wordier, but more clear about what to expect from the setting. |
From the docs:
In this example however, setting 'fit' to 'true' causes the ticks to be positioned according to the x value of the data points while setting to false actually makes the ticks appear nicely spaced.
The text was updated successfully, but these errors were encountered: