Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocean] Some primitive property mappings fail (camel cased v. hypenated properties) #283

Open
alvinwan opened this issue Nov 24, 2018 · 0 comments

Comments

@alvinwan
Copy link

I saw #52 but that appears to not address camel-cased properties. I'm working with a-ocean and found that amplitudeVariance did not appear to change visibly, when I updated it:

  1. For this primitive, the ocean should be completely still if amplitude = amplitudeVariance = speed = speedVariance = 0. Here's a simple example where all are zero and yet, the ocean still moves: http://jsfiddle.net/wz02xybp/1/. I tried hyphenated and all-lowercase versions of the property name as well (in case I just misunderstood)
  2. I copied and pasted the a-ocean source in and found that data.amplitudeVariance wasn't being updated. http://jsfiddle.net/wz02xybp/2/ (I console.log(data.amplitudeVariance...)
  3. However, if I change the mapping to amplitudevariance (all lowercase, http://jsfiddle.net/wz02xybp/3/) or amplitude-variance (hypenated, http://jsfiddle.net/wz02xybp/4/), all is well.

Does this look about right? Or have I simply misinterpreted an AFRAME mapping convention (e.g., amplitudeVariance actually means to use variance-amplitude)? Happy to make a PR if appropriate.

@vincentfretin vincentfretin changed the title Some primitive property mappings fail (camel cased v. hypenated properties) [ocean] Some primitive property mappings fail (camel cased v. hypenated properties) Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant