Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistakes of Workload calculation #441

Open
fly-dragon211 opened this issue Mar 8, 2023 · 5 comments
Open

Mistakes of Workload calculation #441

fly-dragon211 opened this issue Mar 8, 2023 · 5 comments

Comments

@fly-dragon211
Copy link

The calculation of $Mss_{GPU}$ and $Mss_{CPU}$ may have some mistakes. The following is my calculation procedure:

image

while in the paper:
image

@shadow150519
Copy link

i think they do make the mistake :(

@shadow150519
Copy link

The calculation of MssGPU and MssCPU may have some mistakes. The following is my calculation procedure:

image

while in the paper: image

Can you tell me do they build the system using the wrong result or just a slip of the pen ?

@ymjiang
Copy link
Member

ymjiang commented Mar 28, 2023

@shadow150519 Yes, this is a typo in the paper. Despite the typo, the final conclusion in equation (6) is right and BytePS correctly implements the traffic allocation strategy. Thank you for pointing out this.

@shadow150519
Copy link

@ymjiang
base on tc = tg and eq3, eq4, eq5, i get the following result

$$ M_{ss_{GPU}} = \frac{k - 1}{-kn + 2k -n}*M $$

$$M_{ss_{CPU}} = \frac{2(1-n)}{-kn+2k-n}*M$$

and the topt should be the following result

$$ t_{opt} = \frac{2(1-n)}{(-kn+2k-n)*B}*M $$

eq7 is wrong and should be the following

$$ \gamma_{\alpha} = \frac{\frac{2(n-1)M}{nB}}{t_{opt}} = \frac{kn-2k + n}{n} $$

$$ \gamma_{p} = \frac{\frac{nM}{kB}}{t_opt} = \frac{n(-kn+2k-n)}{2k(1-n)}$$

i think these should be the correct result

@shadow150519
Copy link

i think you do the calculation totally wrong in section 4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants