Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external approval support issue's statement #11578

Open
mahuihuang opened this issue Apr 9, 2024 · 0 comments
Open

external approval support issue's statement #11578

mahuihuang opened this issue Apr 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mahuihuang
Copy link

Is your feature request related to a problem?

relay_client define request Payload

https://github.com/bytebase/bytebase/blob/main/backend/plugin/app/relay/relay_client.go#L36

// CreatePayload is the message to create external approval.
type CreatePayload struct {
	IssueID     string    `json:"issueId"`
	Creator     string    `json:"creator"`
	Title       string    `json:"title"`
	Description string    `json:"description"`
	Project     string    `json:"project"`
	Statement   string    `json:"statement"`
	CreateTime  time.Time `json:"createTime"`
}

https://github.com/bytebase/bytebase/blob/main/backend/utils/utils.go#L507

actually request Payload

	id, err := relayClient.Create(node.Endpoint, &relay.CreatePayload{
		IssueID:     fmt.Sprintf("%d", issue.UID),
		Title:       issue.Title,
		Description: issue.Description,
		Project:     issue.Project.ResourceID,
		CreateTime:  issue.CreatedTime,
		Creator:     issue.Creator.Email,
	})

Describe the solution you'd like

nil

Additional context

No response

@mahuihuang mahuihuang added the enhancement New feature or request label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant