Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irlba's implementation of prcomp loses rotation rownames #59

Open
leahrosen opened this issue Apr 29, 2021 · 1 comment
Open

irlba's implementation of prcomp loses rotation rownames #59

leahrosen opened this issue Apr 29, 2021 · 1 comment

Comments

@leahrosen
Copy link

Hi, I've rewritten my code to replace prcomp with prcomp_irlba (so much faster 🙌 ), and got an error because, downstream, I call rownames of the rotation matrix, however in irlba's implementation, the rotation matrix has lost the rownames. It would be very useful if you could add back the rownames, to allow more seamless conversion between prcomp and irlba.

@bwlewis
Copy link
Owner

bwlewis commented Apr 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants