Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of pycraf compatiable with version 2.11 or later of python-sgp4 #30

Open
OrbitalMechanic opened this issue May 25, 2020 · 4 comments

Comments

@OrbitalMechanic
Copy link

Will there be a version of pycraf compatible with version 2.11 or later of python-sgp4? If so, what time frame can we expect to see it?

Sam Dupree.

@bwinkel
Copy link
Owner

bwinkel commented May 25, 2020

Indeed, it is planned to work on the satellite sub-package in the near future (few weeks), to add some functionality for satellite constellation simulations. The current plan is to migrate to cysgp4 in the process, as it integrates nicely with numpy arrays (and broadcasting). Under the hood, it uses a different C++ library such that the results will be slightly(!) different from python-sgp4. Do you have strong feelings about this? If there are good reasons to also continue to support python-sgp4 one could probably make it so that both 3rd party packages are supported.

@OrbitalMechanic
Copy link
Author

OrbitalMechanic commented Jun 2, 2020 via email

@bwinkel
Copy link
Owner

bwinkel commented Jun 2, 2020

Thanks a lot, this is very good information indeed. I may make this a user option then, perhaps. It should not be a huge problem, as pycraf already "wraps" the python-sgp4 (and adds azimuth/elevation calculation). However, because of this, python-sgp4 will likely perform somewhat worse, as cysgp4 does everything in parallelized C-loops. Not sure, if it is a big problem in practice though.

If I may ask, what do you use pycraf for?

@atrawog
Copy link

atrawog commented Jun 23, 2020

I just started to use pycraf, but this appears to be a quite simple problem. The Satellite object in the current python-sgp4 version 2.12 has been moved from sgp4.io to sgp4.model.

I made a small fix #32 and pycraf together with sgp4 2.12 appears to work fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants