Possibly uninitialized data deref in SNP module

[ZetaTwo]

When using DirectIP.snp to connect, at least two users have reported a crash like this:

The address corresponds to this line:

bwapi/1.16.1/SNP_DirectIP/src/SNP/SNPModule.cpp

Line 323 in 45360dc

*addr = nullptr;

The fact that the references address is ASCII "::re" suggests it's dereferencing an uninitialized pointer. I'm trying to debug this further but I'm posting this here for documentation in the meantime.

[dgant]

Is it happening every time or intermittently?

[NiteKat]

Is this using Chaos Launcher multi-instance? If so, are you launching Chaos Launcher as Admin? I believe Local PC mode crashes if it does not have admin privileges.

[ZetaTwo]

This is not happening for me at all but for two other users:

User A: first it did not happen, then later after having restarted their computer it seems to be happening every time now. They are not using ChaosLauncher or anything like that, just starting the exe normally.

User B: It happens for them every time. They are not using ChaosLauncher either.

[ZetaTwo]

My least bad idea so far is that the "::re" is part of the "::recv failed" string in the library and this is caused by some UAF or possibly overflow somewhere. I've put together debug builds of the SNP and sent to the two people experiencing this plus instructions to enable crash dumps. Will update once I have more info.