Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First frame of ZergBirth order has a Zerg Egg with no BuildType #850

Open
Cmccrave opened this issue Feb 24, 2020 · 2 comments
Open

First frame of ZergBirth order has a Zerg Egg with no BuildType #850

Cmccrave opened this issue Feb 24, 2020 · 2 comments
Labels
bug 🐞 Good first issue 👶 An issue that someone not entirely familiar with the codebase can take a look at

Comments

@Cmccrave
Copy link

image

Just on the first frame the order occurs, the type of the unit stays as Zerg Egg, but the BuildType is now UnitTypes::None.

Possibly related to #613

@NiteKat
Copy link

NiteKat commented Feb 24, 2020

This was documented on 4.4. Appears to be related to this switch: https://github.com/bwapi/bwapi/blob/v4.4.0/bwapi/BWAPI/Source/BWAPI/UnitUpdate.cpp#L567

There is no case for the ZergBirth order, and since the type is still ZergEgg, there is no buildUnit, and the supply for the egg is 0.

@NiteKat
Copy link

NiteKat commented Feb 24, 2020

Adding ZergBirth into the switch case appears to resolve the issue, and verified I don't see any weird effects with Lurkers, Guardians, or Devourers. I cannot think of any other cases to test for side effects from this change.

@heinermann heinermann added bug 🐞 Good first issue 👶 An issue that someone not entirely familiar with the codebase can take a look at labels Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Good first issue 👶 An issue that someone not entirely familiar with the codebase can take a look at
Projects
None yet
Development

No branches or pull requests

3 participants