Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #245

Closed
stephenotalora opened this issue May 20, 2019 · 6 comments
Closed

TypeScript support #245

stephenotalora opened this issue May 20, 2019 · 6 comments
Labels
💬 question Further information is requested

Comments

@stephenotalora
Copy link

stephenotalora commented May 20, 2019

this is more of a questions and as such it can be flagged as so. As the trend is to continue to move towards TypeScript are there any plans to add TS support to react-window?

@bvaughn
Copy link
Owner

bvaughn commented May 20, 2019

Nope.

Definitely Typed repo is the place to go for libdefs of this library

@bvaughn bvaughn closed this as completed May 20, 2019
@bvaughn bvaughn added the 💬 question Further information is requested label May 20, 2019
@lishine
Copy link

lishine commented Apr 14, 2020

why not, why not let somebody type it ?

@bvaughn
Copy link
Owner

bvaughn commented Apr 14, 2020

Nope. Because I don't want to maintain it. DefinitelyTyped works for a lot of libraries. It can work for this one too.

All of the confused reactions above seem to ignore that even "letting someone else" do this requires work from me- to review, merge, publish releases, triage any new issues complaining about invalid types, etc.

@stephenotalora
Copy link
Author

stephenotalora commented Apr 14, 2020

@bvaughn @lishine there’s already an npm module that can be used independently. Please take a look at / npm i @types/react-window https://www.npmjs.com/package/@types/react-window

@bvaughn I originally asked the question last year. Apologies for the overhead this may have caused.

@bvaughn
Copy link
Owner

bvaughn commented Apr 14, 2020

Thanks for sharing the line, @stephenotalora !

@lishine
Copy link

lishine commented Apr 14, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants