Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batched update option for interactive mode #195

Closed
wants to merge 2 commits into from
Closed

Add batched update option for interactive mode #195

wants to merge 2 commits into from

Conversation

XOR-op
Copy link

@XOR-op XOR-op commented Feb 13, 2022 •
edited by ondrejfuhrer

This PR add support for batched update option for interactive mode.

To be specific, I add option b for each interaction. And for each app answered with b, I record it in a temporary list, then perform upgrade after all interactions are answered.

Fixes #182 (asks for the same feature enhancement)

@ondrejfuhrer
Copy link
Collaborator

Thank you for your contribution @XOR-op 🙂 I was just wondering, why you went this path? My idea was to not have yet another option but change slightly the way it works - you would add it to the batch when "y" was given and then do the upgrades. Do you think it makes sense? Could you make that change?

@XOR-op
Copy link
Author

XOR-op commented Apr 27, 2022

Thank you for your contribution @XOR-op 🙂 I was just wondering, why you went this path? My idea was to not have yet another option but change slightly the way it works - you would add it to the batch when "y" was given and then do the upgrades. Do you think it makes sense? Could you make that change?

You're right. However I have no experience in Ruby, so I'm not sure if I would break something in that manner. Also I've pushed a new commit to recover original flag.

@ondrejfuhrer ondrejfuhrer mentioned this pull request Dec 25, 2022
Merged
1 task
@ondrejfuhrer
Copy link
Collaborator

Hey @XOR-op , I've come up with an alternative, where I first asks for the input and then execute it. Feel free to look into the solution or propose any changes (#224).

@ondrejfuhrer
Copy link
Collaborator

Closed in favour of #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejfuhrer ondrejfuhrer ondrejfuhrer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow interactive selection before starting upgrades
2 participants
@XOR-op @ondrejfuhrer