Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update axios #464

Closed
wants to merge 3 commits into from
Closed

Update axios #464

wants to merge 3 commits into from

Conversation

fernandopasik
Copy link

@fernandopasik fernandopasik commented Dec 6, 2023 •
edited

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, link to documentation update:

Summary

Since axios has some security issues like axios/axios#6006. Updates axios to the latest version

fixes #463

Does this PR introduce a breaking change?

No

Other information

@fernandopasik
Copy link
Author

I'm not sure if the failing task is from this:

[WARNING] Some CI configuration options were not found (githubAccessToken)

@fernandopasik
Copy link
Author

@charpeni could it be that there's an outdated github access token in the CI?

@fernandopasik
Copy link
Author

The tests are passing

Test Suites: 3 passed, 3 total
Tests:       22 passed, 22 total
Snapshots:   9 passed, 9 total
Time:        2.599 s

The problem is that coverage can't be upload to coveralls

[error] "2024-01-08T17:54:00.987Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2024-01-08T17:54:00.989Z"  'input: ' ''
[error] "2024-01-08T17:54:00.989Z"  'error from convertLcovToCoveralls'

/home/circleci/bundlewatch/node_modules/coveralls/bin/coveralls.js:19
      throw err;
      ^
Failed to parse string
(Use `node --trace-uncaught ...` to show where the exception was thrown)
make: *** [Makefile:54: test] Error 1

Exited with code exit status 2

@fernandopasik fernandopasik deleted the update-axios branch February 3, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Axios security issues
1 participant
@fernandopasik