Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results page URL issues #34

Open
a-axton opened this issue May 15, 2019 · 7 comments
Open

Results page URL issues #34

a-axton opened this issue May 15, 2019 · 7 comments

Comments

@a-axton
Copy link

a-axton commented May 15, 2019

Do you want to request a feature or report a bug?
Bug

What is the current behavior?

  1. The url shortener is returning a 400 status code in CircleCI
  2. Without the shortened url, the details page is returning a 413 error

If the current behavior is a bug, please provide the steps to reproduce.
All I'm doing is running bundlewatch from CircleCI, everything seems to be working except for the detail page. Here's the output from CircleCI https://gist.github.com/a-axton/95f9eea5ce0d34bd12b8b78f56787683

What is the expected behavior?
Link should take me to a working details page, I think it might be from too many characters in the URL.

@danielstocks
Copy link

danielstocks commented Jun 13, 2019

I can confirm having the same issue, I can verify that it's due to the generated URL string is too long, so firebase refuses to shorten it.

I could verify this by removing one bundle at a time and found a threshold when it happened. So basically a limitation in how many characters a GET request URL can handle. Not sure if this is solvable without changing logic in the bundlewatch-service. Will take a look.

https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers

@danielstocks
Copy link

danielstocks commented Jun 13, 2019

Btw I came here from bundlesize, which unfortunately suffers the same limitation

@jakebolam
Copy link
Member

It would be great to re-build bundlewatch to avoid this limitation. Some work was started in #28 by @francoiscampbell

@rtymchyk
Copy link

Are there any workarounds for this? We have quite a number of chunks 😅

@danielstocks
Copy link

danielstocks commented Nov 1, 2019

For anyone else looking at this. After a few months I came across https://bundle-analyzer.com and it works fine with Next.js and 40+ chunks for larger sites.

@rtymchyk
Copy link

rtymchyk commented Nov 1, 2019

@danielstocks This is amazing, incredibly polished service. Thanks for sharing.

EDIT: Gonna eat my words, bundle-analyzer has deteriorated. There is no longer a maintainer and the web dashboard is down.

@cheapsteak
Copy link
Contributor

Thoughts on referencing bundle-analyzer's approach to store the report inside Github checks?
image

(note that their code is GPLv3 and can't just copy here under MIT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants