New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fundamental instructions missing from documentation #242
Comments
Also on the "Using bundlewatch" page nowhere does it say how and where to make the GitHub App work. I assume that this piece information is missing: In your CI that runs in every PR, run - uses: actions/checkout@v2
- run: npm ci
- run: npm run build
- run: npm run bundlewatch
env:
BUNDLEWATCH_GITHUB_TOKEN: 8fc08494d51041a393beb |
And also the fundamental information that the token is actually a secret and should not be public. |
And also that before the PR Action starts working, it needs to be pushed to the default branch, otherwise you get this when trying to add it in a PR:
|
Thank you @fregante! I was about to give up on this but have it now working to some extend. There is also that https://github.com/jackyef/bundlewatch-gh-action but I couldn't get it to work. |
Also, this information is misleading
I am using Travis and I have no such variables. Definitely none prefixed with "CI". Also not according to Travis: UPDATE: I now see that internally it uses some library called ci-env which abstracts fetching these env vars from many different CI services. This should be better explained anyhow as it made me lose much time |
It would also be super nice if the format of the |
On both the readme and the site, these are the instructions:
Now run the last command:
❯ npm run bundlewatch npm ERR! missing script: bundlewatch
The text was updated successfully, but these errors were encountered: