Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SearchBar should not inherit all the Config properties from Input #571

Open
veej opened this issue Apr 6, 2023 · 0 comments
Open
Labels
bug Something isn't working triage-needed

Comments

@veej
Copy link
Member

veej commented Apr 6, 2023

Description of the bug

SearchBar is currently inheriting all the Config properties from Input, omitting only the iconSize and adding a few other specific config keys: https://github.com/buildo/bento-design-system/blob/main/packages/bento-design-system/src/SearchBar/Config.ts#L5.

However, we added a few config options to Input that make sense only for the Input and not for the SearchBar (e.g. passwordShowIcon/passwordHideIcon/passwordIconSize). It might be better to cherry-pick the properties instead of omitting, or define a common baseConfig.

Playroom reproduction

No response

Version

v0.17.2

What browsers are you seeing the problem on?

No response

@veej veej added bug Something isn't working triage-needed labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage-needed
Projects
Status: No status
Development

No branches or pull requests

1 participant