Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify target attribute in links #32

Open
byroot opened this issue Dec 9, 2015 · 6 comments
Open

Allow to specify target attribute in links #32

byroot opened this issue Dec 9, 2015 · 6 comments

Comments

@byroot
Copy link

byroot commented Dec 9, 2015

Ref: #29
So the link feature is awesome:

bk-links

One little downside: I wish I could specify target="_blank" because output pages are quite big and take a while to load, so it's a bummer when you forget to open the link in a new tab and that you have to load the output page again after.

@toolmantim @keithpitt @mipearson what do you think?

I tried to implement it myself, but my go is really not good :/

@keithpitt
Copy link
Member

We could probably make it an boolean in the sequence? I think it's a valid case to be able to open it in a new tab.

@keithpitt
Copy link
Member

Also, how do you do the linking? Is it something you'd be able to open source? :D:D

@byroot
Copy link
Author

byroot commented Dec 10, 2015

Also, how do you do the linking? Is it something you'd be able to open source? :D:D

In part maybe. But it's quite dirty / coupled to our application ATM.

@keithpitt
Copy link
Member

What do you think of this @mipearson?

@ticky
Copy link
Contributor

ticky commented Mar 17, 2017

The only thing I’d suggest is we be wary of the fact that this has potential security considerations (especially considering this is linking to user-specified content), albeit ones Google don’t seem too concerned about

@mipearson
Copy link
Contributor

I think a solution for this is that we add target="_blank" to the links rather than a custom thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants