Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected output in logs #73

Open
gchan opened this issue Mar 20, 2024 · 0 comments
Open

Unexpected output in logs #73

gchan opened this issue Mar 20, 2024 · 0 comments

Comments

@gchan
Copy link

gchan commented Mar 20, 2024

It's not an issue for me (the plugin still works) but thought the unexpected output could be confusing for some users.

I set up a new test suite which uses the Test Collector Plugin. It runs successfully and uploads to TA but I noticed some unexpected output:

/var/lib/buildkite-agent/plugins/github-com-buildkite-plugins-test-collector-buildkite-plugin-v1-10-1/hooks/pre-exit: line 179: kill: (1249389) - No such process

Line 179 takes me to this line in the code:

if ! kill -0 "${uploads_in_progress[index]}" > /dev/null; then

Is the problem that we are only redirecting stdout to /dev/null? Is it intentional we are not redirecting stderr?

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant