allow using either --file or --sync-dir + allow use of relative path in args
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects the following args: [ file, sync-dir,, state-dir, cache-dir ]
Araxeus
force-pushed
the
allow-using-either-file-or-sync-dir
branch
from
97ae5a1
to
50d5540
Compare
|
Good thing that tests exist Forgot to add the following line so cache dir wasnt properly set And one test is failing because it checked that settings I'll push a fix later today |
* remove `test_peru_file_and_sync_dir_must_be_set_together` since that rule is removed * fix the behavior and formatting of `--cache-dir` and `--state-dir` params
Araxeus
force-pushed
the
allow-using-either-file-or-sync-dir
branch
from
08d2962
to
7e27bd3
Compare
|
@oconnor663 I Pushed fixes for the failing tests, (tho the current matrix testing is broken since it requires some older python versions that don't exist on the GitHub runner) |
|
@oconnor663 heyo :) |
|
Thanks for the ping. Apologies for leaving this hanging so long. I've been spending less time on open source stuff in general this year. |
|
All test are passing except those that depand on non-existant local python versions 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow using either
--fileor--sync-dirwithout needing the otherallow use of relative path in args
those changes combined can for example enable the following command in a monorepo:ㅤ
fix #235