Git 2.34 changed read-tree's handling of .gitignore files #221
Comments
colindean
added a commit
to colindean/peru
that referenced
this issue
Dec 17, 2021
This comes by recommendation of @newren in the thread related to buildinspace#221. I could only see this being regrettable if a new filter type was added that Peru doesn't want. I speculate that such is unlikely so this is probably safe. [1]: https://lore.kernel.org/git/CABPp-BEZj4opBu+wo2whOCHrck1qMjZXfDY9tAE5FbB=Wr9F_w@mail.gmail.com/
oconnor663
added a commit
that referenced
this issue
Feb 25, 2022
This was broken by Git 1.34, and I haven't found a good way to fix it to recover the old behavior. This is a corner case behavior that almost no one cares about in practice, so it's not worth blocking progress on the entire project. If it stays broken forever, it's not the end of the world. See #221.
|
I'm going to disable the test as a temporary workaround. There's a good chance "temporary" actually means "permanent" here, but that wouldn't be the end of the world, because this |
oconnor663
changed the title
oconnor663
added a commit
that referenced
this issue
Feb 25, 2022
This was broken by Git 2.34, and I haven't found a good way to fix it to recover the old behavior. This is a corner case behavior that almost no one cares about in practice, so it's not worth blocking progress on the entire project. If it stays broken forever, it's not the end of the world. See #221.
oconnor663
pushed a commit
that referenced
this issue
Feb 25, 2022
This comes by recommendation of @newren in the thread related to #221. I could only see this being regrettable if a new filter type was added that Peru doesn't want. I speculate that such is unlikely so this is probably safe. [1]: https://lore.kernel.org/git/CABPp-BEZj4opBu+wo2whOCHrck1qMjZXfDY9tAE5FbB=Wr9F_w@mail.gmail.com/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previously read-tree would not respect
.gitignorefiles by default. Now it does, which breaks one of our tests. I've started an email thread upstream to get advice about this: https://lore.kernel.org/git/CA+6di1m91q70PfaFq0DKMsmd_Tb6XBB7H9AYPhwawX12cZgtGQ@mail.gmail.com/T/#uThe text was updated successfully, but these errors were encountered: