New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] bb login
should be a no-op if the user already has a valid API key
#6468
Comments
I think making However, I am a bit skeptical regarding making a network call to check the API Key validity. Let me check with the team to see if there is a better way. |
Also call GetUser when API key is found so that we could check if the key is still valid. Close #6468
Also call GetUser when API key is found so that we could check if the key is still valid. Close #6468
Gentle ping on this. We would like to add |
Sorry about that. My PR is going through review but folks are OOO 😅 I will try to push the fix forward for a release next week 🙇 |
This is being built and deployed now. Once it's done, you can use |
Is your feature request related to a problem? Please describe.
bb login
currently always opens a webpage, even if the user is logged in.Describe the solution you'd like
bb login
should instead do nothing when the user is logged it, probably with a message telling them they are already logged in.Describe alternatives you've considered
We could check
git config --local buildbuddy.api-key
before callingbb login
, but that only tells us if they have an API key set. It doesn't tell us if that key is valid.bb login
should be able to do both of those steps, and only direct them to the web page if they need to do something there.The text was updated successfully, but these errors were encountered: