Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildBuddy GitHub app: Submodules #6234

Open
ivucica opened this issue Mar 26, 2024 · 1 comment
Open

BuildBuddy GitHub app: Submodules #6234

ivucica opened this issue Mar 26, 2024 · 1 comment

Comments

@ivucica
Copy link

ivucica commented Mar 26, 2024

Hello!

I have a toy project repo where I've quasi-vendored a few other rules repos by adding them as Git submodules, and then using WORKSPACE rules to pull them in via local_repository().

These are perfectly usable with GitHub Actions, but if I get the BuildBuddy GH app to run bazelisk et al, it doesn't check out the submodules first. I haven't spotted a way to make it do so.

While I could by now switch over to pulling them in via a HTTP archive (perhaps write a wrapper repo rule that falls back to that approach if the submodule is not checked out, or write a wrapper rule that runs git submodule update --init if the submodule is not checked out), it would be a useful feature in BuildBuddy as well.

@sluongng
Copy link
Contributor

I would recommend using git_repository instead of local_repository and git submodule as Bazel will lazily fetch the git repositories only when they are needed for the build.

Our BuildBuddy Workflows should work with git_repository today. There is a small bug reported this week that would prevent using git_repository on private repos, we are actively working on a fix for this.

@ivucica could you switch from using git submodule to git_repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants