Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildBuddy GitHub app: Passes --heap_dump_on_oom #6226

Open
ivucica opened this issue Mar 25, 2024 · 1 comment
Open

BuildBuddy GitHub app: Passes --heap_dump_on_oom #6226

ivucica opened this issue Mar 25, 2024 · 1 comment

Comments

@ivucica
Copy link

ivucica commented Mar 25, 2024

Hi,

I'm playing with an old toy project of mine, and I've locked it down to Bazel 3.3.1.

Unfortunately, unlike running Bazelisk locally, the environment set up without buildbuddy.yaml sets up some config files that seem to make Bazelisk pass on --heap_dump_on_oom to Bazel, which is unsupported in 3.3.1 and a bunch of versions after that.

Luckily, it looks like none of my custom Starlark rules are broken up to 6.5.0, but still, --heap_dump_on_oom being passed without an easy opt-out made moving to something newer mandatory, even though RBE itself with local Bazelisk seems to otherwise work perfectly fine.

@siggisim
Copy link
Member

siggisim commented Mar 25, 2024

Hey @ivucica - we recently added this flag to make debugging OOMs easier.

Looks like the flag was added in Bazel 5.0 which was released back in January of 2022. Agreed we should probably add a config option to buildbuddy.yaml to disable this or not apply it if we detect an old Bazel version. (cc @bduffany)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants