Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md does not specify commit message body and footer information #9

Open
EliKalter opened this issue May 12, 2023 · 2 comments
Open

CONTRIBUTING.md does not specify commit message body and footer information #9

EliKalter opened this issue May 12, 2023 · 2 comments

Comments

@EliKalter
Copy link

EliKalter commented May 12, 2023 •
edited

In the CONTRIBUTING.md file it says all commit messages must include a header a body and a footer,
It has full information about the header but it does not have any information about the body nor the footer,
what are they suppose to be? how should they look? etc.
Also in the part about the header there is information about the type but not about the scope and subject
@EliKalter
Copy link
Author

EliKalter commented May 12, 2023 •
edited

This is only partially covered in #7 .

@etorreborre
Copy link
Member

Thanks @EliKalter I have addressed your concerns in a new commit in #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etorreborre @EliKalter