Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Images? #668

Open
Yorizuka opened this issue Jul 19, 2023 · 3 comments
Open

Missing Images? #668

Yorizuka opened this issue Jul 19, 2023 · 3 comments

Comments

@Yorizuka
Copy link
Contributor

in the default XML views/res/btn_default_small_transparent.xml & views/res/btn_default_small_transparent_dark.xml both have references to drawable(s) I can't find & nothing in views folder has any file with the set drawable names.

should there be images for btn_default_small_normal_hover & btn_default_small_normal_hover_dark?
@GrimMaple
Copy link
Collaborator

Unfortunately, I won't be able to tell. Unless something is explicitly broken I don't think this needs any changes.
Can you find any situation when those images are a neccesity?

@Yorizuka
Copy link
Contributor Author

Yorizuka commented Jul 26, 2023 •
edited

No I can not, I can't find anything broken that would need the images. I just find it odd that there is defines for images that don't exist.

@GrimMaple
Copy link
Collaborator

If there are unnecessary defines they should be removed

@GrimMaple GrimMaple reopened this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yorizuka @GrimMaple