Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the slot value train-arriveby not updated? #103

Open
westofsun opened this issue May 11, 2022 · 2 comments
Open

Why is the slot value train-arriveby not updated? #103

westofsun opened this issue May 11, 2022 · 2 comments

Comments

@westofsun
Copy link

Hi.When I use the test_dials to test my dst model.I found that some slot-values about train-arriveby are not update in the ground truth.
Such as MUL2294 :
"transcript": "i need to travel on saturday from cambridge to london kings cross and need to leave after 18:30",
"system_transcript": "train tr0427 leaves at 19:00 on saturday and will get you there by 19:51. the cost is 18.88 pounds. want me to book it?",
"transcript": "yes please book the train for 1 person and provide the reference number"

From above we can see that the slot-value train-arriveby has changed in the dialog.But why this slot-value is not changed in the ground truth?
This confused me a lot,hope you can have a look,thank you!

@jianguoz
Copy link
Collaborator

Hi, I think the ground truth should be updated here, i.e., the value should be either after 18:30 or 19:00.

@westofsun
Copy link
Author

Thank you for your reply.But I still get some problems.
First,do we have to add a slot type to express the situation such as: bofore or after xxx ?
Second,the question above is not one.Not just the ground truth doesn't update the slot train-leaveAt,
but the ground truth doesn't add the slot train-arriveby .So I just want to know if this slot should be added here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants