Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect default JDBC columns names #489

Closed
barteksc opened this issue May 7, 2024 · 2 comments
Closed

Incorrect default JDBC columns names #489

barteksc opened this issue May 7, 2024 · 2 comments
Labels
bug

Comments

@barteksc
Copy link

barteksc commented May 7, 2024 •
edited

Starting with 8.11, it looks like there is a mistake when assigning default columns names in the io.github.bucket4j.distributed.jdbc.AbstractJdbcProxyManagerBuilder class:

    private String idColumnName = "state";
    private String stateColumnName = "id";

These two columns names are swapped.
@vladimir-bukhtoyarov
Copy link
Collaborator

Hello @barteksc

Thank you for reporting. I will deploy fix at weekend. Currently, just specify column names explicitly.

vladimir-bukhtoyarov added a commit that referenced this issue May 11, 2024
@vladimir-bukhtoyarov
#489 prepare fix version
00e91ae
vladimir-bukhtoyarov added a commit that referenced this issue May 11, 2024
@vladimir-bukhtoyarov
#489 fix typos + enhance testsuite
2a84d08
@vladimir-bukhtoyarov
Copy link
Collaborator

Fix released with version 8.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barteksc @vladimir-bukhtoyarov