Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [UI + API]: customLogo and customCSS API + UI difference #5945

Closed
1 task done
ndeet opened this issue Apr 23, 2024 · 0 comments
Closed
1 task done

[Bug] [UI + API]: customLogo and customCSS API + UI difference #5945

ndeet opened this issue Apr 23, 2024 · 0 comments
Assignees

Comments

@ndeet
Copy link
Contributor

ndeet commented Apr 23, 2024

What is your BTCPay version?

v1.13.1

How did you deploy BTCPay Server?

docker

What happened?

When you use the update store API you can set customLogo and customCSS properties by setting an URL. The update works but:

  1. in the UI it is not visible because it is an file upload field

  2. if you uploaded custom Logo + CSS via these file upload fields they will still be shown on the store UI despite being replaced by the URLs

  3. in the checkout the URLs set via API are present and the custom uploaded files are not

image

Additional question: why are logo and CSS not settable as ans URL like over the API?

EDIT: Ok, some more testing, seems that logo + CSS set over API only loads on V1 checkout page, on V2 the uploaded logo + CSS is used instead. So I guess the bug is basically that the API for logo + CSS do not work for V2 checkout?

cc @dennisreimann

How did you encounter this bug?

  1. upload custom logo + css via the file uploader
  2. update the store with custom logo + css URLs (like https://example.com/mylogo.png and .../mycss.css)
  3. revisit the store settings UI

Relevant log output

No response

What browser do you use?

No response

Additional information

No response

Are you sure this is a bug report?

  • I confirm this is a bug report
@dennisreimann dennisreimann self-assigned this Apr 23, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Apr 23, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Apr 26, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue Apr 26, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue May 7, 2024
dennisreimann added a commit to dennisreimann/btcpayserver that referenced this issue May 7, 2024
NicolasDorier pushed a commit to dennisreimann/btcpayserver that referenced this issue May 8, 2024
NicolasDorier pushed a commit to dennisreimann/btcpayserver that referenced this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants