Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittest compatible subset of test suite #89

Open
jayvdb opened this issue Sep 11, 2019 · 0 comments
Open

unittest compatible subset of test suite #89

jayvdb opened this issue Sep 11, 2019 · 0 comments
Labels
enhancement New feature or request needs tests Tests are absent or incomplete for this
Milestone

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Sep 11, 2019

The test suite is the canonical usage of the library.

We are uncovering problems related to pre-existing state, which we are mostly shielded from because pytest avoids pre-existing state, and is quite a mature test runner.

A good way to uncover other pre-existing state problems is to run (a subset of) the test suite on multiple test runners. This would mean using unittest style classes for some of it, and would mean those other test runners might not be exposed to all of the tests & features so some of the more complicated bits might be skipped and the bugs not found.

Another important reason to have some unittest compatible tests is getting pytest running on all python implementations is prohibitive as noted at #81 (comment)

@jayvdb jayvdb added enhancement New feature or request needs tests Tests are absent or incomplete for this labels Sep 11, 2019
@bskinn bskinn added this to the v2.0 milestone Sep 16, 2019
@bskinn bskinn mentioned this issue Sep 16, 2019
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs tests Tests are absent or incomplete for this
Projects
Development

No branches or pull requests

2 participants