Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit ._buf in RandomTextIO? #67

Open
bskinn opened this issue Aug 27, 2019 · 1 comment
Open

Remove explicit ._buf in RandomTextIO? #67

bskinn opened this issue Aug 27, 2019 · 1 comment
Labels
maybe This may or may not be implemented refactor Restructuring existing code in a (hopefully) no-op way to the public API
Milestone
v2.0

Comments

@bskinn
Copy link
Owner

bskinn commented Aug 27, 2019

Do we still need to retain the reference to RandomTextIO()._buf, now that access to the buffer contents after close is provided by the callback in _PersistedBytesIO?
@bskinn bskinn added maybe This may or may not be implemented refactor Restructuring existing code in a (hopefully) no-op way to the public API labels Aug 27, 2019
@bskinn bskinn added this to the v2.0 milestone Aug 27, 2019
@jayvdb
Copy link
Contributor

jayvdb commented Sep 4, 2019

I haven't had time to look at it. If it can be removed without reducing functionality, go for it.

bskinn added a commit that referenced this issue Sep 5, 2019
@bskinn
DEV: Remove ._buf on RandomTextIO
e393d66 
No longer needed now that callback method for persisting the
underlying stream contents is implemented.

Closes #67.
@bskinn bskinn mentioned this issue Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maybe This may or may not be implemented refactor Restructuring existing code in a (hopefully) no-op way to the public API
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

DEV: Remove ._buf on RandomTextIO bskinn/stdio-mgr
2 participants
@jayvdb @bskinn