Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle repeated stream closure in various circumstances? #66

Open
bskinn opened this issue Aug 27, 2019 · 0 comments
Open

How to handle repeated stream closure in various circumstances? #66

bskinn opened this issue Aug 27, 2019 · 0 comments
Labels
question Further information is requested
Milestone

Comments

@bskinn
Copy link
Owner

bskinn commented Aug 27, 2019

With #53, #64 et al. allowing instantiation of StdioManager objects with a useful lifetime before and after use as a context manager, as well as independent of a managed context, the question arises as to what the behavior should be when a given stream in the internal tuple is .close()d more than once.

At this point, I believe a repeated .close() on a stream will raise ValueError? In some situations this is probably desired; but in others it might not be.

Or, for consistency, the behavior should perhaps always be the same.

This is loosely related to #42, in that the exception behavior is more a part of the API than not.

@bskinn bskinn added the question Further information is requested label Aug 27, 2019
@bskinn bskinn added this to the v2.0 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant