Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "quick" pre-check of CUBE file contents for faster rejection at cmdline #81

Open
bskinn opened this issue Nov 27, 2017 · 0 comments

Comments

@bskinn
Copy link
Owner

bskinn commented Nov 27, 2017

In cases where the data contained in a CUBE file is invalid in some way, a "quick" pre-check to ensure the correct data dimensionality would allow a faster fail-exit at the commandline.

The best way is probably, per here, something like sum(1 for _ in re.finditer('[^\\s\\n][\\s\\n]+[^\\s\\n]')). There would still be the unavoidable overhead of loading the file, but maybe this would be faster....

OTOH, the UX load wait could be improved by a file-load status bar, implemented as part of #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant