Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surely HammerOptions should be __hammerConfig? #35

Open
sinemacula opened this issue Jul 2, 2019 · 4 comments
Open

Surely HammerOptions should be __hammerConfig? #35

sinemacula opened this issue Jul 2, 2019 · 4 comments

Comments

@sinemacula
Copy link

I have searched the entire repository and am unable to find any reference to hammerOptions. Surely this is meant to be __hammerConfig?

See the following line:

const localOptions = el.hammerOptions && el.hammerOptions[recognizerType];

Should be:

const localOptions = el.__hammerConfig && el.__hammerConfig[recognizerType];

Otherwise localOptions is redundant is it not?

@zjffun
Copy link

zjffun commented Sep 6, 2019

I'm also find that, but el.__hammerConfig can't directly use as Hammer option.

Should we use ref get DOM and set localOptions?

@ptandler
Copy link

Related to #29 - in case this would be fixed, is there any way to actually set el.__hammerConfig (or el.hammerOptions?

@parkyh1974
Copy link

I need more detailed information to use config.
Is there any detailed information?

@ptandler
Copy link

I ended up importing hammerjs directly to configure global options, see https://github.com/ptandler/enneagram-explorer/blob/master/src/main.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants