Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use polite scraping #19

Open
brry opened this issue Jun 18, 2020 · 1 comment
Open

use polite scraping #19

brry opened this issue Jun 18, 2020 · 1 comment
Labels
enhancement

Comments

@brry
Copy link
Owner

brry commented Jun 18, 2020 •
edited

Consider using polite for downloading files.
Maybe this is already conceptually fine with no re-downloads and CURL handle in https://github.com/brry/rdwd/blob/master/R/indexFTP.R#L121
@brry
Copy link
Owner Author

brry commented Jun 18, 2020

indexFTP might be fine, but dataDWD uses download.file with no checks. When calling dataDWD with, say, 500 urls, once banned, it will still keep trying the rest of the urls. Definitely not polite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brry