Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use browsh with portable firefox bin on Windows #464

Open
nickelberg opened this issue Jan 31, 2023 · 0 comments
Open

Cannot use browsh with portable firefox bin on Windows #464

nickelberg opened this issue Jan 31, 2023 · 0 comments
Labels

Comments

@nickelberg
Copy link

nickelberg commented Jan 31, 2023

Using:
.\browsh.exe --firefox.path "C:\Temp\firefox_portable\firefox.exe"
Results in browsh not working.

browsh

Possible reason:
Windows browsh build uses registry to get path, version and flavor of firefox as seen in:
browsh/interfacer/src/browsh/firefox_windows.go

Possible solution 1:
Add option to statically define path, version and flavor in config file or using launch parameters.

Possible solution 2:
Skip registry check altogether when "--firefox.path" parameter is used.
As for other two variables, trust user that version and flavor are optimal when he statically defines firefox binary.

@tombh tombh added the bug label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants