Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookmarklet fails to load jquery #4

Open
thinsoldier opened this issue Apr 7, 2013 · 3 comments
Open

bookmarklet fails to load jquery #4

thinsoldier opened this issue Apr 7, 2013 · 3 comments

Comments

@thinsoldier
Copy link

I get endless console.log "Loading jQuery" messages.

The script element for //raw.github.com/browserstate/ajaxify/master/ajaxify-bookmarklet-helper.js gets successfully added to the end of my

But the line in that file:
window.jQuery || document.write('<script src="//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>');

doesn't seem to actually work.

I'm using firefox 20. That document.write line doesn't seem to work when run by itself via the console. But document.write('foo'); does work.

@ghost
Copy link

ghost commented Apr 15, 2013

Should be work fine now!

@ghost ghost closed this as completed Apr 15, 2013
@thinsoldier
Copy link
Author

Nope. On some sites that have no js library at all I get an infinie loop of "loading jquery" console.log calls.

On a site that already has jquery I get a blank page after clicking the bookmarklet. Seems to be some issue with document.write in firefox.

Could you add an actual anchor containing the bookmarklet code to the readme so people can just click+drag that to their bookmarks toolbar.

I haven't tested in chrome yet because chrome's bookmarks won't let me paste the bookmarklet code into them. I probably would need to edit it to look like a real url without entities for ://

@thinsoldier
Copy link
Author

In which browser on which platforms does the bookmarklet work for you?

@ghost ghost reopened this May 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant