Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with dependencies cache #122

Open
masarakki opened this issue Nov 30, 2015 · 3 comments
Open

bug with dependencies cache #122

masarakki opened this issue Nov 30, 2015 · 3 comments

Comments

@masarakki
Copy link

At first, BrowserfieyProcessor load a file that contains string of 'require' like var required = true;.
This file should not be browserified, but BrowserfiyProcessor#commonjs_module? think it is a browserifyable file, and check dependencies.
Off cause, it is not browserifiable file, so browserify --list return no lines and cached to @dependencies .

Then, Processor load other file that really browserifiyable like var $ = require("jquery");,
however, @dependencies is already cached with [], so BrowserifyProcessor#commonjs_module? always returns false.

@masarakki
Copy link
Author

after 2.0.x, BrowserifyProcessor is changed to Singleton, so this problem occurs.

@mizchi
Copy link

mizchi commented Dec 18, 2015

I encoutered too

@cymen
Copy link
Member

cymen commented Dec 18, 2015

2.0.3 has been released with improvements to the CommonJS detection part so that var required = true; will no longer mark the file as being CommonJS. Do you still see the issue with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants