Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Preview of the page on hover. #1279

Open
Gozala opened this issue Apr 7, 2017 · 4 comments
Open

Preview of the page on hover. #1279

Gozala opened this issue Apr 7, 2017 · 4 comments
Assignees
Milestone

Comments

@Gozala
Copy link
Contributor

Gozala commented Apr 7, 2017

Once link is hovered we would like to show a preview of the titlebar at the bottom of the page.

@Gozala Gozala added this to the Opening links milestone Apr 7, 2017
@Gozala
Copy link
Contributor Author

Gozala commented Apr 10, 2017

Seems like we could just display a preview for of the titlebar when update-target-url is dispatched on webview.

@patrykadas I think it would be interesting to provide some extra information like:

  1. Does link takes you to the different domain or maybe origin ?
  2. Maybe a different visual if it is an anchor link.
  3. Update our visual if you press when hovering indicating that it will open in background.
  4. Different visual to let you know it's a popup link (opens in a different tab).

As a side note it just occurred to me that we can do a lot better job with pop-up blocker with this UX as if say tab programmatically opens a new tab we can just display our page preview at the bottom again with a question asking user if it's ok to actually open it.

@patrykadas patrykadas self-assigned this Apr 11, 2017
@patrykadas
Copy link
Collaborator

patrykadas commented Apr 13, 2017

domains

@Gozala
Beyond four points mentioned, we could also perhaps provide additional feedback about the format of a link (webpage / media / document). I was playing with few different visual representations of those, I will continue.

I also remember that we were discussing previously to indicate if a link's safe. I know it's difficult to estimate, therefore let's just maybe indicate if it's https or http by utilizing green color.
https://www.youtube.com/watch?v=sKCTzRDAvuw

@Gozala
Copy link
Contributor Author

Gozala commented Apr 26, 2017

For anchor links I'm not even sure doing the same preview as we for any other link would make sense given that (presumably):

  1. Page will just scroll down (unless you have cmd key pressed)
  2. We won not be creating an entry in the trail. (or would we ?)

Maybe we should just show an update in the title-bar itself ?

Also I don't think I gathered from your comment on how do we want to indicate that if you click this link it will load in a different tab vs current, regardless if that's because you have cmd pressed or not.

As a side note it might be cool if we could use cmd as modifier so if it's target=_blank link but you press cmd we could still load it in the same tab instead. I personally have wished that some sites would not just spawn new tabs. With a visual feedback of where things open it becomes plausible to provide open in this tab behavior

@patrykadas
Copy link
Collaborator

links

I think this could work, CMD could be utilized to provide bi-directional switching of behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants