Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Handle theme-color updates even after first paint #1073

Open
Gozala opened this issue Jun 2, 2016 · 1 comment
Open

Handle theme-color updates even after first paint #1073

Gozala opened this issue Jun 2, 2016 · 1 comment
Assignees
@Gozala
Labels
Help needed mentored P2
Milestone
Backlog

Comments

@Gozala
Copy link
Contributor

Gozala commented Jun 2, 2016

This is a followup on #1055:

about:newtab page sets a meta tag on theme changes to update titlebar so it matches the wallpaper.

Hmm, doesn't appear to work here.

You're right, it seems that meta changes don't trigger theme updates if they happen after first pain. How about I create a separate pull for fixing that.

P.S.: It seems that there was flow in logic & theme colors were not actually ever picked up if they happened after load.
@Gozala Gozala added this to the All hands milestone Jun 2, 2016
@Gozala Gozala added the P2 label Jun 2, 2016
@Gozala Gozala self-assigned this Jun 2, 2016
@Gozala
Copy link
Contributor Author

Gozala commented Jun 2, 2016

I made it P2 as I don't think it's less important thing for All Hands

@Gozala Gozala removed this from the All hands milestone Jun 23, 2016
@Gozala Gozala modified the milestone: Backlog Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Gozala Gozala

Labels
Help needed mentored P2
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@Gozala