Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Rendering glitches during tab switch (crossfade) animation #1068

Open
Gozala opened this issue Jun 1, 2016 · 8 comments
Open

Rendering glitches during tab switch (crossfade) animation #1068

Gozala opened this issue Jun 1, 2016 · 8 comments
Assignees
@paulrouget
Labels
P3 Servo
Milestone
Backlog

Comments

@Gozala
Copy link
Contributor

Gozala commented Jun 1, 2016

rendering-glitches
@Gozala Gozala added the Servo label Jun 1, 2016
@Gozala Gozala added this to the All hands milestone Jun 1, 2016
@Gozala Gozala added the P1 label Jun 1, 2016
@Gozala
Copy link
Contributor Author

Gozala commented Jun 1, 2016

P.S.: I think it's regression from the last servo update as I have not seen it before.

@paulrouget
Copy link
Contributor

This has always been here. I never investigated, but I know that the WR folks have been working on tab switching improvements for WR2.

@Gozala
Copy link
Contributor Author

Gozala commented Jun 3, 2016

This has always been here. I never investigated, but I know that the WR folks have been working on tab switching improvements for WR2.

I'm pretty sure crossfade used to work better in the past. I think we should get rid of the crossfade if we don't have a fix it in time for "All Hands"

@Gozala
Copy link
Contributor Author

Gozala commented Jun 3, 2016

@pcwalton has some fix in mind with iframe backgrounds (which I did not fully understood). If it's that fix not going to work out let's ditch the crossfade or try a different animation.

@paulrouget
Copy link
Contributor

Agreed.

pcwalton added a commit to pcwalton/webrender that referenced this issue Jun 10, 2016
@pcwalton
Enable blending on render targets.
629c514 
It was disabled as a fix for servo#166, but that caused regressions on pages
that depend on blending. The issues related to the blur on box shadows
discussed in that issue seem to be resolved now, so the clear-color
solution works fine.

Addresses browserhtml/browserhtml#1068.
@pcwalton pcwalton mentioned this issue Jun 10, 2016
Merged
@Gozala Gozala removed this from the All hands milestone Jun 23, 2016
@paulrouget
Copy link
Contributor

There's no glitches anymore, but it's jumpy.

@paulrouget
Copy link
Contributor

For the tech demo we probably want to disable the opacity animation. I don't know how to do that though.

@paulrouget paulrouget added P3 and removed P1 labels Jun 30, 2016
@Gozala Gozala mentioned this issue Aug 11, 2016
Closed
@Gozala
Copy link
Contributor Author

Gozala commented Apr 5, 2017

I'm inclined to close this. @paulrouget is there associated issue on the servo side ? Should I create one ?

@Gozala Gozala modified the milestone: Backlog Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulrouget paulrouget

Labels
P3 Servo
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Gozala @paulrouget