Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

Rename Flags to Options #1050

Open
Gozala opened this issue May 31, 2016 · 9 comments
Open

Rename Flags to Options #1050

Gozala opened this issue May 31, 2016 · 9 comments
Milestone

Comments

@Gozala
Copy link
Contributor

Gozala commented May 31, 2016

Many modules define Flags type that is passed to init to construct an instance. Flags implies booleans while types tend to contain all kinds of fields there for we should choose a better name like Options.

@Gozala
Copy link
Contributor Author

Gozala commented Aug 17, 2016

This is pretty straight forward work if someone wants to contribute.

@Coder206
Copy link
Contributor

@Gozala I would like to contribute to this issue

@Gozala
Copy link
Contributor Author

Gozala commented Aug 17, 2016

@Coder206 it's all yours :)

@Coder206
Copy link
Contributor

@Gozala I think this can be closed.

@Coder206
Copy link
Contributor

(when you get a chance)

@Gozala Gozala modified the milestone: Backlog Apr 5, 2017
@Coder206
Copy link
Contributor

Coder206 commented Apr 5, 2017

@Gozala What's missing in this issue? (shouldn't it be closed?)

@Gozala
Copy link
Contributor Author

Gozala commented Apr 5, 2017

@Gozala What's missing in this issue? (shouldn't it be closed?)

Not much but, I there are still few instances it seems

@Coder206
Copy link
Contributor

Coder206 commented Jun 25, 2017

@Gozala Do you know of a way to ensure there are no build errors? I have found numerous instances, even strings that contain "Flags". When I change anything, it always re-compiles without any errors. I tried writing random text and when running npm run live-server it still builds the new bad code. (though I am not sure it works)

@jdanford
Copy link
Contributor

That's what the flow check command is for, but even on master it comes up with a bunch of errors, so it might be hard to get much out of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants