Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per-site adblock content setting #87

Closed
csagan5 opened this issue Jul 8, 2018 · 6 comments
Closed

Use per-site adblock content setting #87

csagan5 opened this issue Jul 8, 2018 · 6 comments

Comments

@csagan5
Copy link
Contributor

csagan5 commented Jul 8, 2018

Chromium already has per-site adblock content settings; Bromite could use that setting and add an extra option in the three-dots menu "Adblock whitelist site" or similar to disable adblocks on a specific site.

@DragoCubed
Copy link

I would absolutely love this. Sites like SBS on Demand don't work with adblockers and I think it deserves ads.

@Sterilize
Copy link

Would it be possible to do the same for Javascript.?

@fredgolightly

This comment has been minimized.

@BetaLyte
Copy link

GelloMod have (had) this under Site Settings, which seems like a logical place to put it. I'm guessing it's implemented somewhere in here: https://github.com/LineageOS/android_packages_apps_Gello/blob/cm-14.1/src/com/android/browser/preferences/SiteSpecificPreferencesFragment.java

@ghost
Copy link

ghost commented Mar 22, 2019

@csagan5 Any progress on this for both adblocking and Javascript? I'd like to disable Javascript on some sites and whitelist some sites from adblocking.

@csagan5
Copy link
Contributor Author

csagan5 commented Sep 16, 2019

It should now possible to change whitelist settings for each site, as in 77.0.3865.81 the native Chromium engine is used.

Edit: confirmed.

@csagan5 csagan5 closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants