Video playback broken on Android 10 arm64 #445

alex-kinokon · 2019-12-21T07:35:40Z

Affected device/platforms

Android OS version	CPU	GPU	disable AImageReader	disable hw video decode	users
9	64-bit	Adreno 540	✔	✔	@HigH-HawK
10	64bit	Adreno 640	?	✔	@proteriax @Jaminanim
10	64bit	Adreno 540	?	✔	@kkkrist @l-easwar-akiyama @r3muxd
10	64bit	Adreno 630	?	✔	@ben-page @valpamp
10	64bit	ARM Mali-G76	✔	✔	@aluo-x
10	64bit	Adreno 506	?	✔	@kyelbek

Bromite version

Version: 79.0.3945.94
Arch: arm64
Android version: 10.0.3
Device model: OnePlus 7

Is this bug about the SystemWebView?

No

Is the bug reproducible with latest version?

Yes

Can the bug be reproduced with corresponding Chromium version?

No

Is the bug a crash?

No

Describe the bug

Video playback is broken on Vimeo and other video websites other than YouTube.
Attempting to play a video on a web page will cause the page to flicker.

Steps to reproduce the bug

Steps to reproduce the behavior:

Go to https://vimeo.com/channels/staffpicks/323783503
Click play

Expected behavior

Video starts playing.

Actual behavior

It does not.

Screenshots

The text was updated successfully, but these errors were encountered:

csagan5 · 2019-12-21T08:43:08Z

Cannot reproduce this issue. @nikolowry perhaps you can test too?

Outi-s · 2019-12-21T10:04:00Z

Can't reproduce this issue either. Video played fine for me.

csagan5 · 2019-12-21T10:06:31Z

@subi54 thanks for testing.

@proteriax any clue in your adb logcat? perhaps your Android OS does not have some codec decoding capability?

kkkrist · 2019-12-21T13:14:08Z

I'm also experiencing this, on Twitter for example. The first couple of frames play (with sound), then the player crashes. On Chrome 79.0.3945.93 the same videos do play without any issues. I'm on a Pixel 2 XL with Android 10 (Dec). Will try to pull a logcat.

ghost · 2019-12-21T15:08:33Z

I'm able to reproduce the issue on YouTube.

As @kkkrist said,

The first couple of frames play (with sound), then the player crashes.
the same videos do play without any issues.

This exactly describes the issue. Pulling a logcat now, few moments please...

csagan5 · 2019-12-21T15:10:33Z

@kkkrist @Icejr sure, take your time. I might have reproduced it sometimes as well, but over longer periods of playback time.

I think the issue might have affected v78 as well.

ben-page · 2019-12-21T22:08:11Z

I'm have this issue for most videos as well. I actually get the Bronite keeps stopping dialog. Although, the Close App button doesn't kill Bromite. It did not happen on the last release. And the sites work in Chrome stable.

This is from a Rooted, but otherwise stock Pixel 3 XL with Android 10 and the December patch.

[logcat_12-21-2019_16-10-15.zip]

kkkrist · 2019-12-21T22:09:25Z

Here are some logs:

[removed]

This issue wasn't present in v78 on my end, would've noticed for sure I think.

csagan5 · 2019-12-21T22:35:24Z

The crash found in your logcat:

[12-21 22:57:27.025 11775:11775 F/DEBUG]*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
[12-21 22:57:27.026 11775:11775 F/DEBUG]Build fingerprint: 'google/taimen/taimen:10/QQ1A.191205.008/5974827:user/release-keys'
[12-21 22:57:27.026 11775:11775 F/DEBUG]Revision: 'rev_10'
[12-21 22:57:27.026 11775:11775 F/DEBUG]ABI: 'arm64'
[12-21 22:57:27.027 11775:11775 F/DEBUG]Timestamp: 2019-12-21 22:57:27+0100
[12-21 22:57:27.027 11775:11775 F/DEBUG]pid: 11707, tid: 11760, name: ImageReader-1x1  >>> org.bromite.bromite:privileged_process0 <<<
[12-21 22:57:27.027 11775:11775 F/DEBUG]uid: 10292
[12-21 22:57:27.027 11775:11775 F/DEBUG]signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x0  0000000000000000  x1  0000000000002df0  x2  0000000000000006  x3  00000070ecefe980
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x4  802322110c49122b  x5  802322110c49122b  x6  802322110c49122b  x7  42606863644c3fff
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x8  00000000000000f0  x9  000000717e9384e0  x10 0000000000000000  x11 0000000000000001
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x12 000000000001ac70  x13 0000000000000002  x14 0000000000000000  x15 0000007180af3020
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x16 000000717ea048c0  x17 000000717e9e2060  x18 00000070a06ca000  x19 00000000000000ac
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x20 0000000000002dbb  x21 00000000000000b2  x22 0000000000002df0  x23 00000000ffffffff
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x24 00000070eceff020  x25 00000070ecefed50  x26 0000007180860138  x27 00000000000fd000
[12-21 22:57:27.027 11775:11775 F/DEBUG]    x28 0000007089252000  x29 00000070ecefea30
[12-21 22:57:27.027 11775:11775 F/DEBUG]    sp  00000070ecefe960  lr  000000717e996170  pc  000000717e9961a0
[12-21 22:57:27.040 11775:11775 F/DEBUG]
backtrace:
[12-21 22:57:27.040 11775:11775 F/DEBUG]      #00 pc 00000000000821a0  /apex/com.android.runtime/lib64/bionic/libc.so (abort+176) (BuildId: b58d049709674405423a8d8de1a37f56)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #01 pc 00000000000186d4  /system/lib64/libmediandk.so (__cfi_check_fail+24) (BuildId: 070ca91395586cffc473ba31eee93910)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #02 pc 000000000001ade4  /system/lib64/libmediandk.so (__cfi_check+7652) (BuildId: 070ca91395586cffc473ba31eee93910)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #03 pc 0000000000046ef4  /apex/com.android.runtime/bin/linker64 (__dl__ZN15CFIShadowWriter7CfiFailEmPvS0_S0_+124) (BuildId: 52561db5295b9b5f246e5c95d06a6b3c)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #04 pc 0000000000001160  /apex/com.android.runtime/lib64/bionic/libdl.so (__cfi_slowpath+64) (BuildId: 12e0c86c59cc11545d28655d0e51c65a)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #05 pc 0000000000029f2c  /system/lib64/libmediandk.so (AImageReader::CallbackHandler::onMessageReceived(android::sp<android::AMessage> const&)+404) (BuildId: 070ca91395586cffc473ba31eee93910)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #06 pc 0000000000016960  /system/lib64/libstagefright_foundation.so (android::AHandler::deliverMessage(android::sp<android::AMessage> const&)+48) (BuildId: c58afc2199618f4e88ce8d6482bcc221)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #07 pc 000000000001a4a4  /system/lib64/libstagefright_foundation.so (android::AMessage::deliver()+100) (BuildId: c58afc2199618f4e88ce8d6482bcc221)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #08 pc 00000000000173cc  /system/lib64/libstagefright_foundation.so (android::ALooper::loop()+564) (BuildId: c58afc2199618f4e88ce8d6482bcc221)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #09 pc 00000000000137c0  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+312) (BuildId: 1a9baf080e66cccc6106194a0c4147f8)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #10 pc 00000000000c1794  /system/lib64/libandroid_runtime.so (android::AndroidRuntime::javaThreadShell(void*)+140) (BuildId: de057b63e21f6c0880ad2d2827b8a843)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #11 pc 00000000000e2364  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+36) (BuildId: b58d049709674405423a8d8de1a37f56)
[12-21 22:57:27.041 11775:11775 F/DEBUG]      #12 pc 0000000000083d98  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: b58d049709674405423a8d8de1a37f56)

It is a stagefright/ImageReader crash, and I think it's already reported upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=977583

Can the bug be reproduced with corresponding Chromium version?

No

@proteriax the bug can most likely be reproduced with Chromium, you could not test with the corresponding version because it was/is not yet released.

csagan5 · 2019-12-21T22:42:37Z

There is already a patch in Bromite to counteract the buggy AImageReader in Android 10, I will add in next release the additional workaround specified in the upstream issue; please follow the upstream issue for the proper solution.

kkkrist · 2019-12-21T22:54:22Z

Thanks for having looked into it! The Chrome version I mentioned above and which plays videos just fine is indeed 32-bit (came pre-installed and was updated via Play Store), the Bromite version I was using is 64-bit.

csagan5 · 2019-12-21T23:00:32Z

@kkkrist we use Chromium to verify whether bugs like these are from upstream or from Bromite patches, unfortunately the Chromium version matching to current Bromite version is not available at the moment but will be in the next days.

If upstream does not test/release/maintain the 64-bit version we might have to drop it too, although there are some advantages in using it.

alex-kinokon · 2019-12-21T23:12:36Z

@csagan5 Thank you. I didn’t notice the latest Chromium version does not match.

tiagossa1 · 2019-12-27T20:50:03Z

This is still happening on 79.0.3945.100. For me, I just open a YouTube link, sometime it plays for 1-2 seconds, then refreshes the page and plays for another 1-2 secs, then it doesn't play at all.

Sometimes, I'm lucky and after the first crash, it loads the video just fine.

csagan5 · 2019-12-28T05:53:28Z

@tiagossa1 @proteriax @kkkrist @luisnogueira @godwintgn can you please test with the corresponding Chromium version 79.0.3945.100?

https://www.bromite.org/chromium

kkkrist · 2019-12-28T07:54:53Z

Yes, it's still crashing on Twitter videos with the 64-bit version, whereas 32-bit works. Same with Chromium 79.0.3945.100.

csagan5 · 2019-12-28T08:08:57Z

@kkkrist thanks for testing. Since it is happening with the corresponding Chromium version then the best way to get this fixed is to ask about it upstream (no need to mention Bromite, the Chromium issue tracker is about Chromium).

The fixes reported in https://bugs.chromium.org/p/chromium/issues/detail?id=977583 were not effective as they are already in place for current version.

csagan5 · 2019-12-30T12:54:10Z

I have read that #disable-accelerated-video-decode can mitigate this issue on arm64.

nikolowry · 2019-12-30T15:53:55Z

Just wanted to add some more context to this issue, I cannot replicate it but I believe that's due to being on Android 9 (Lineageos 16 with MicroG) -- so this seems to be isolated to Android 10.

tiagossa1 · 2019-12-30T21:56:32Z

@csagan5 That fixes the problem. Looks like there's no force closing disabling Accelerated Video Decode. It's working just fine.

csagan5 · 2019-12-31T17:17:15Z

@nikolowry the issue can be replicated on Android 9 without Bromite's patch; for Android 10 the patch is instead ineffective.

It seems to be a bug within Android stagefright itself, so we have to wait upstream on this.

esrk · 2020-01-04T07:02:34Z

I have read that #disable-accelerated-video-decode can mitigate this issue on arm64.

Can confirm that this solves the issue in Android 10 (December Security Patch).
Device - Oneplus 5T

aluo-x · 2020-06-26T05:01:03Z

Actually, even playing videos from imgur in the m.reddit.com, then clicking forward and then going back to an auto resuming video can trigger freezing.

csagan5 · 2020-06-26T07:13:08Z

But with every Bromite 83 release

You need to report it when it happens, including the release number and the crash log.

Actually, even playing videos from imgur in the m.reddit.com, then clicking forward and then going back to an auto resuming video can trigger freezing.

Do you have a crash log? It could be a regression in v83.

aluo-x · 2020-06-26T23:37:58Z

Good points. I've hesitated to file a bug since I cannot consistently reproduce it. There are no errors printed out in chrome://gpu, and bromite does not crash, just freezes until I switch away then switch back.

Just tested the arm32 version, and it definitely freezes far less than the arm64 version. Hopefully v84 of chrome fixes this regression.

csagan5 · 2020-06-27T14:53:38Z

@aluo-x only ways forward would be to check the upstream issue tracker and/or attach the Android Studio profiler to see what's going on.

aluo-x · 2020-07-16T06:25:35Z

https://www.androidcentral.com/chrome-android-finally-get-64-bit-variant-and-much-better-performance

Looks like Google has been testing Chrome 84 with 64bit builds. Maybe the work around will no longer be necessary?

csagan5 · 2020-09-28T19:14:54Z

For those interested I am running some tests for v86 in #755

csagan5 · 2020-11-21T10:01:13Z

I am going to disable AImageReader for Qualcomm chipsets, see discussion in #814 if interested.

csagan5 · 2021-03-19T13:10:28Z

I am planning to have the AImageReader flag enabled by default in a future release of Bromite; please test on the current release by going to chrome://flags and enabling the relative flag.

valpamp · 2021-03-19T13:51:13Z

Working flawlessly here on OnePlus 6 (Adreno 630), tested on both Facebook and Youtube using the latest build available on the F-Droid repo.

csagan5 · 2021-03-19T18:13:06Z

Working flawlessly here on OnePlus 6 (Adreno 630), tested on both Facebook and Youtube using the latest build available on the F-Droid repo.

And you enabled the #enable-image-reader flag?

valpamp · 2021-03-19T18:21:00Z

Working flawlessly here on OnePlus 6 (Adreno 630), tested on both Facebook and Youtube using the latest build available on the F-Droid repo.

And you enabled the #enable-image-reader flag?

Yes, I enabled the flag, restarted and then I tried some videos on Youtube and Facebook. I just double checked to make sure that I didn't mess up and here it is, the flag is enabled:

Edit: now tested also on Vimeo, still works perfectly.

csagan5 · 2021-03-19T20:52:04Z

Great, thanks; I will enable AImageReader by default on next release.

Revert "gpu/android: Remove setup for disabling AImageReader." This reverts commit dcd5a39. Revert "Remove flags to enable/disable AImageReader." This reverts commit 463fa0f. Restore GPU bug blacklist for AImageReader on ARM and Qualcomm CPUs Restore the AImageReader blacklist for ARM/Qualcomm chipsets which causes crashes on Android 9 and 10 (at different code locations). See discussions at: * bromite/bromite#445 * bromite/bromite#814 * bromite/bromite#1005 License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html

Revert "gpu/android: Remove setup for disabling AImageReader." This reverts commit dcd5a39. Revert "Remove flags to enable/disable AImageReader." This reverts commit 463fa0f. Restore GPU bug blacklist for AImageReader on ARM and Qualcomm CPUs Restore the AImageReader blacklist for ARM/Qualcomm chipsets which causes crashes on Android 9 and 10 (at different code locations). See discussions at: * bromite/bromite#445 * bromite/bromite#814 * bromite/bromite#1005 License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html Change-Id: I0db87f4107c94f68e846f06f365b8eefd0076599

csagan5 closed this as completed Dec 21, 2019

csagan5 added the upstream bugs which are identified in upstream Chromium label Dec 21, 2019

csagan5 mentioned this issue Dec 22, 2019

Videos don't work #448

Closed

toraddict mentioned this issue Dec 23, 2019

HTML5 videos not playing #449

Closed

csagan5 pinned this issue Dec 28, 2019

csagan5 changed the title ~~Video playback broken~~ Video playback broken on arm64 Dec 28, 2019

This comment has been minimized.

Sign in to view

csagan5 mentioned this issue Jan 1, 2020

Video player freezes after 1 second #455

Closed

csagan5 mentioned this issue Sep 28, 2020

Video playback tests for v86 #755

Closed

uazo mentioned this issue Nov 20, 2020

[Android 9] AImageReader video playback crash #814

Closed

This was referenced Mar 15, 2021

Video playback outside fullscreen mode glitches #1005

Closed

Video Playback Not Working/Flicker ARM64 Android 9 #497

Closed

Video playback broken on Android 10 arm64 #445

Video playback broken on Android 10 arm64 #445

Comments

alex-kinokon commented Dec 21, 2019 • edited by csagan5

Affected device/platforms

Bromite version

Is this bug about the SystemWebView?

Is the bug reproducible with latest version?

Can the bug be reproduced with corresponding Chromium version?

Is the bug a crash?

Describe the bug

Steps to reproduce the bug

Expected behavior

Actual behavior

Screenshots

csagan5 commented Dec 21, 2019

Outi-s commented Dec 21, 2019

csagan5 commented Dec 21, 2019

kkkrist commented Dec 21, 2019

ghost commented Dec 21, 2019

csagan5 commented Dec 21, 2019

ben-page commented Dec 21, 2019 • edited

kkkrist commented Dec 21, 2019 • edited

csagan5 commented Dec 21, 2019

Can the bug be reproduced with corresponding Chromium version?

csagan5 commented Dec 21, 2019 • edited

kkkrist commented Dec 21, 2019

csagan5 commented Dec 21, 2019

alex-kinokon commented Dec 21, 2019

tiagossa1 commented Dec 27, 2019 • edited

csagan5 commented Dec 28, 2019

kkkrist commented Dec 28, 2019

csagan5 commented Dec 28, 2019

csagan5 commented Dec 30, 2019

nikolowry commented Dec 30, 2019

tiagossa1 commented Dec 30, 2019

csagan5 commented Dec 31, 2019

This comment has been minimized.

esrk commented Jan 4, 2020 • edited

aluo-x commented Jun 26, 2020

csagan5 commented Jun 26, 2020

aluo-x commented Jun 26, 2020

csagan5 commented Jun 27, 2020

aluo-x commented Jul 16, 2020

csagan5 commented Sep 28, 2020

csagan5 commented Nov 21, 2020

csagan5 commented Mar 19, 2021

valpamp commented Mar 19, 2021

csagan5 commented Mar 19, 2021

valpamp commented Mar 19, 2021 • edited

csagan5 commented Mar 19, 2021

alex-kinokon commented Dec 21, 2019 •

edited by csagan5

ben-page commented Dec 21, 2019 •

edited

kkkrist commented Dec 21, 2019 •

edited

csagan5 commented Dec 21, 2019 •

edited

tiagossa1 commented Dec 27, 2019 •

edited

esrk commented Jan 4, 2020 •

edited

valpamp commented Mar 19, 2021 •

edited