Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table head colour does not contrast with darkmode enabled #33

Open
Seanom opened this issue Oct 19, 2021 · 1 comment
Open

Table head colour does not contrast with darkmode enabled #33

Seanom opened this issue Oct 19, 2021 · 1 comment

Comments

@Seanom
Copy link

Seanom commented Oct 19, 2021

Table head content does not inherit the lighter colour when dark mode is enabled

To Reproduce
Add a table to a page

Test content This is not visible in dark mode
Content This content is visible in dark mode

Expected behavior
The table head follows the behaviour of the table and inherits the lighter colour when dark mode is enabled

Screenshots
image

image

@Seanom
Copy link
Author

Seanom commented Oct 19, 2021

Also spotted this appears to be an issue for the code block.

I've resolved it by adding the following to _tmp\style.css in keeping with the other prose fixes, but also noticed a colour inherit applied to the original thead/code selectors resolves this

.dark .prose thead {
  --tw-text-opacity: 1;
  color: rgba(156, 163, 175, var(--tw-text-opacity));
}

.dark .prose code {
  --tw-text-opacity: 1;
  color: rgba(156, 163, 175, var(--tw-text-opacity));
}

I'm happy to add a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant