Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete column names after spherizing #74

Open
michaelbornholdt opened this issue Jul 15, 2021 · 6 comments
Open

Delete column names after spherizing #74

michaelbornholdt opened this issue Jul 15, 2021 · 6 comments

Comments

@michaelbornholdt
Copy link
Contributor

@FloHu noticed that the original names of the features are carried through after spherizing.
We might want to not do that since it can confuse people actually using the consensus data later on then. I think they should just be named feature_1 .. x

@michaelbornholdt
Copy link
Contributor Author

@gwaygenomics ? You ok with this?

@gwaybio
Copy link
Member

gwaybio commented Jul 19, 2021

the feature names for spherized data still hold meaning though, right?

@michaelbornholdt
Copy link
Contributor Author

I dont think so
They are a transformed space where dim 1 is that Principal component with the highest variation.
@shntnu ?

@shntnu
Copy link
Collaborator

shntnu commented Jul 20, 2021

There’s some version of it where you do rotate it back got the original space

@michaelbornholdt
Copy link
Contributor Author

ok hm, so we keep the column names then? Or we differentiate depending on if we rotate back ?

@shntnu
Copy link
Collaborator

shntnu commented Jul 20, 2021

Indeed the feature name should represent the space in which they are in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants