if_match compare fails if locale uses "," as decimal mark

[twwn]

From my log:

conky: Bad arguments: '0,0 ' and ' 10.0'
conky: compare failed for expression '0,0 < 10.0'

These compares are all similar to this one:

${if_match ${downspeedf enp2s0} < 100.0}

The compare still fails if the argument is written with ",". Explicitly setting conky's locale to en_US.UTF-8 works for now.

(This didn't happen in 1.9.0.)

[ghost]

I have the same problem.

[thhart]

Same here, can you tell please how to set a specific LOCALE for conky?

[twwn]

You preface the command with eg.

LC_ALL=C conky

[thhart]

Thanks, however it turns out comparing is failing in general with fraction numbers:

conky: compare failed for expression ' 12,61 >= 10 '

${if_match ${top cpu 1} >= 10 }${color red}\
${else}${color}\
${endif}\

[thhart]

Sorry my fault, the locale was not set it worked now. I use following startup script now:

#!/bin/bash

export LANG=en_US.UTF-8
export LC_ALL=C

sleep 5 && conky

Side note: It looks like it is in algebra.cc: enum arg_type get_arg_type. I recommend to use a locale aware number parser.

[mswanson-me]

Is this issue still outstanding in the current version of Conky? If so, please update the issue. Otherwise, the issue will be closed in 2 weeks.

[su8]

@lasers Can you have a look ?

[lasers]

@su8 I tried. Not familiar with locale. Tried Italy. Didn't get commas to display. Maybe I did it wrong.

[lasers]

@su8 I tried git bisect here to 1.9.0. Earlier tags does not contain cmake stuffs. :-(

US.

0B // False
56.9K // True
16.9K // False
544B // False
74.9K // True
88.4K // True
13.9K // False

DK.

conky: Bad arguments: '0,0' and '50.0'
conky: compare failed for expression '0,0>50.0'
0B // True
conky: Bad arguments: '0,0' and '50.0'
conky: compare failed for expression '0,3>50.0'
307B // True
^Cconky: Bad arguments: '0,3' and '50.0'
conky: compare failed for expression '0,3>50.0'
350B // True

[lasers]

@su8 Just in case you missed the latest comment, I can test this now.

[su8]

This line is skipped when using locales that use ','

conky/src/algebra.cc

Line 158 in 7bca0ca

if (*p == '.') {

and returns

conky/src/algebra.cc

Line 168 in 7bca0ca

return ARG_BAD;

which causes the "bad argument" to be printed

conky/src/algebra.cc

Line 227 in 7bca0ca

if (type1 == ARG_BAD || type2 == ARG_BAD) {

conky/src/algebra.cc

Line 228 in 7bca0ca

NORM_ERR("Bad arguments: '%s' and '%s'", expr_dup, (expr_dup + idx + 1));

[su8]

Can you test this:

diff --git a/src/algebra.cc b/src/algebra.cc
index 66dfd2d6..4e1d36e2 100644
--- a/src/algebra.cc
+++ b/src/algebra.cc
@@ -155,7 +155,7 @@ enum arg_type get_arg_type(const char *arg) {
   if (p == e + 1) {
     return ARG_LONG;
   }
-  if (*p == '.') {
+  if (*p == '.' || *p == ',') {
     p++;
     while (p <= e) {
       if (isdigit((unsigned char)*p) == 0) {

[lasers]

It works. The numbers get printed with comma too. Lazy copied the example above.

56,9K // True
16,9K // False
544B // False
74,9K // True
88,4K // True
13,9K // False

[lasers]

This happens in the master too. Hmm. Actually, I think this is okay as-is. Duh.

[su8]

Open up a pull request with this change as I'm lazy to do it 🍔

[lasers]

You're not lazy. I'm lasers lazier. I'm wondering about something. If this contains a comma, should you not swap characters around first?

• If comma detected...
  • Replace period with uniq char
  • Replace comma with a period
  • Replace uniq char with comma
• Compare

Does that make sense or am I thinking too much?

[su8]

That's the current country standard, why changing it to other ?

[lasers]

Idk. Noob here. I'll make a pull request at your request. What is if (*p == '.') { for?

[lasers]

Closed via #585 👋