Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: allow to change the bluetooth name #267

Open
josuah opened this issue Sep 27, 2023 · 4 comments
Open

Bluetooth: allow to change the bluetooth name #267

josuah opened this issue Sep 27, 2023 · 4 comments

Comments

@josuah
Copy link
Member

josuah commented Sep 27, 2023

This was requested by an user who wanted to adjust the name of the Bluetooth interface.

@siliconwitch
Copy link
Member

Bluetooth central devices wouldn't like this. They often cache the name so random name changes would create weird behavior. Usually, the fix is to reboot the Bluetooth central, but unless the users know about this, it might cause frustration because they might not be able to connect or scan properly etc

@josuah
Copy link
Member Author

josuah commented Oct 20, 2023

I did not think of these issues, this might be better to be something for custom firmware then.
Thank you for the feedback!

@louisbarrett
Copy link

Bluetooth central devices wouldn't like this. They often cache the name so random name changes would create weird behavior. Usually, the fix is to reboot the Bluetooth central, but unless the users know about this, it might cause frustration because they might not be able to connect or scan properly etc

The assumption on my part is that most people aren't connecting to their devices by name because that could be problematic from the start due to duplicate names, spoofing etc.

I think this is a reasonable ask since the monocle is being discovered either by scanning for the GUID on characteristics (immutable), or the MAC address (also immutable).

Also for security reasons its a good idea to allow users to do this.

P.S - Are there any settings on the monocle that accept persistent changes today?

@josuah
Copy link
Member Author

josuah commented Oct 23, 2023

P.S - Are there any settings on the monocle that accept persistent changes today?

That would need to be a custom build:
https://github.com/brilliantlabsAR/monocle-micropython/blob/main/main.c#L742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants