Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time-zone-aware doctrine types #10

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add time-zone-aware doctrine types #10

wants to merge 9 commits into from

Conversation

varshneydevansh
Copy link

@varshneydevansh varshneydevansh commented Apr 7, 2024 •
edited by kylekatarnls

Proposed introduction of two doctrine types to handle time zones:

carbontz
carbontz_immutable

kylekatarnls
kylekatarnls approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🙏

kylekatarnls
kylekatarnls approved these changes Apr 7, 2024
View reviewed changes
src/Carbon/Doctrine/CarbonTzImmutableType.php Outdated Show resolved Hide resolved
src/Carbon/Doctrine/CarbonTzImmutableType.php Outdated Show resolved Hide resolved
src/Carbon/Doctrine/CarbonTzType.php Outdated Show resolved Hide resolved
@kylekatarnls kylekatarnls changed the title #2835 Add time-zone-aware doctrine types Add time-zone-aware doctrine types Apr 7, 2024
kylekatarnls
kylekatarnls requested changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be fixed. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekatarnls kylekatarnls kylekatarnls requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carbon support for time-zone-aware doctrine types
2 participants
@varshneydevansh @kylekatarnls