From 15e2360230ba082f7c9e5d9665a961f4f0a6cb72 Mon Sep 17 00:00:00 2001
From: Michael Mikonos <127171689+mknos@users.noreply.github.com>
Date: Mon, 15 Apr 2024 03:15:40 +0800
Subject: [PATCH] mkdir: make empty mode an error (#552)

* Follow GNU & OpenBSD mkdir by failing early if the mode string (-m option-argument) was empty
* Previously -m '' was interpreted as -m 0
* Make one error message easier to read
---
 bin/mkdir | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/bin/mkdir b/bin/mkdir
index 27491324..1f4302cb 100755
--- a/bin/mkdir
+++ b/bin/mkdir
@@ -40,8 +40,12 @@ sub usage {
 	}
 
 my $symbolic = 0;
-if (exists $options{'m'} && $options{'m'} =~ /[^0-7]/) {
-    $symbolic = 1;
+if (defined $options{'m'}) {
+	if (length($options{'m'}) == 0) {
+		warn "invalid mode\n";
+		exit EX_ERROR;
+	}
+	$symbolic = 1 if $options{'m'} =~ /[^0-7]/;
 }
 
 # Pay attention before you get lost. The argument list will be turned
@@ -74,7 +78,7 @@ foreach my $directory (@ARGV) {
 
     # Umask is applied on mkdir.
     mkdir $dir => 0777 or do {
-        warn qq 'cannot create make directory "$dir": $!\n';
+        warn "cannot create directory '$dir': $!\n";
         $err++;
         next;
     };