From 099cbdb0dc796286e759d7930387595b7d6700a7 Mon Sep 17 00:00:00 2001
From: Michael Mikonos <127171689+mknos@users.noreply.github.com>
Date: Thu, 14 Mar 2024 16:14:18 +0800
Subject: [PATCH] printenv: retire -? flag (#503)

* Remove -? which is not present in GNU or BSD version of printenv
* The BSD version does not support options starting with a dash
* While here, restructure code to avoid multiple exits; exit code 1 is designated for the (optional) argument not being found in environment
---
 bin/printenv | 45 +++++++++++++--------------------------------
 1 file changed, 13 insertions(+), 32 deletions(-)

diff --git a/bin/printenv b/bin/printenv
index 1f9eb8d0..81664664 100755
--- a/bin/printenv
+++ b/bin/printenv
@@ -14,29 +14,22 @@ License: perl
 
 use strict;
 
-my ($VERSION) = '1.2';
-
-if (@ARGV) {
-    if ($ARGV[0] eq '-?') {
-        $0 =~ s{.*/}{};
-        print <<EOF;
-Usage: $0 [name]
-
-Display the environment. If an argument is given, only the value
-of that variable is displayed.
-
-EOF
-       exit;
-    } elsif (exists $ENV{$ARGV[0]}) {
-	print $ENV{$ARGV[0]}, "\n";
-	exit;
+my ($VERSION) = '1.3';
+
+my $rc = 0;
+my $arg = shift;
+if (defined $arg) {
+    if (exists $ENV{$arg}) {
+        print $ENV{$arg}, "\n";
     } else {
-        exit 1;
+        $rc = 1;
+    }
+} else {
+    while (my ($key, $value) = each(%ENV)) {
+        print "$key=$value\n";
     }
 }
-
-while (my ($key, $value) = each(%ENV)) { print "$key=$value\n"; }
-exit;
+exit $rc;
 
 __END__
 
@@ -55,18 +48,6 @@ printenv [name]
 printenv displays the current environment. If an argument is supplied, only the
 value of that variable is displayed.
 
-=head2 OPTIONS
-
-I<printenv> accepts the following options:
-
-=over 4
-
-=item -?
-
-Print out a short help message, then exit.
-
-=back
-
 =head1 BUGS
 
 I<printenv> has no known bugs.