Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interesting failure to include annotations from .vcf.bgz instead of .vcf.gz #90

Closed
5 tasks
Phillip-a-richmond opened this issue Jul 16, 2018 · 1 comment
Closed
5 tasks

Comments

@Phillip-a-richmond
Copy link

This is not an issue that I need addressed, but I debugged something that may be of interest.

I recently upgraded to the newer release of gnomAD and additionally added the exome set instead of the older EXAC release. However, when I did this, I noticed that my VCFs were no longer getting annotated correctly with gnomad variants. Looking into this further, the only thing that seemed to change was that before I was using gnomad.v1.vcf.gz, and the newer version was gnomad.v2.vcf.bgz. The header information was the same, and I normalized and split the files the same, so it shouldn't have been an issue.

I scratched my head for awhile, and then figured out that the difference was when VCFAnno sees .bgz, it does not correctly parse the annotation file. Simply renaming the files from .bgz to .gz fixed this issue.

I guess within VCFAnno you are parsing the filename, and if you see .vcf.bgz then you interpret it differently than .vcf.gz. I never use .bgz, but kept the convention that gnomAD had. It may be worth mentioning within VCFAnno that .bgz is not acceptable for compressed VCF files when users are trying to develop their own annotation pipelines.

Happy Monday,
Phil

If you have encountered an error, please include:

  • minimal conf and lua files that you are using.
  • urls or actual files for annotations in conf file.
  • minimal query file.
  • the command you used to invoke vcfanno
  • the full error message
@brentp
Copy link
Owner

brentp commented Jul 16, 2018

yea. I should fix this. This is a dup of #81 so I'll close it. and I will try to get this into the next release.

@brentp brentp closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants